Kinkie wrote:
On Fri, Dec 11, 2009 at 8:07 PM, Alex Rousskov
<rouss...@measurement-factory.com> wrote:
This patch removes the following ./configure warnings:
conftest.cpp:34:1: warning: "USE_DISKIO_AIO" redefined
conftest.cpp:35:1: warning: "USE_DISKIO_DISKTHREADS" redefined
The patch allows Squid v3.1 to build on RHEL 5.4 which has autoconf
v2.59. Without the patch, USE_DISKIO_AIO is zero but the corresponding
AIO files are compiled, leading to errors. I do not know if other
platforms are affected.
The patch is not required on my Ubuntu box but I did not investigate
why. It is possible that newer autoconf versions treat AC_DEFINE
redefinitions differently.
It's possible
Alternate approaches are be to use AH_TEMPLATE instead of the first
AC_DEFINE's, or to use #if instead of #ifdef in the header-files. The
latter is already done in trunk, the former is being done in the
autoconf-refactor feature-branch.
This patch also seems to be already in trunk.
In other words, +1.
Yes, +1.
The #if cleanup is usable/needed in 3.1 though if found anywhere in 3.x.
Amos
--
Please be using
Current Stable Squid 2.7.STABLE7 or 3.0.STABLE20
Current Beta Squid 3.1.0.15
