On Wed, 27 Jul 2011 01:32:37 +0200, Henrik Nordström wrote:
ons 2011-07-27 klockan 11:09 +1200 skrev Amos Jeffries:
I mean making the "mode" flag 'vhost' instead of 'accel'. Which
means
we can drop accel and defaultsite= in one change to a parameterized
vhost.
accel was originally optional and implicit if vhost or any other
accelerator mode directive is specified. Actually the accel directive
didn't even exist in the config syntax for a long time. This was
added
rather late in the reverse proxy merging (or after, don't remember).
not sure when accel became a required directive for accelerator mode,
or
if that's a good thing.
In 3.2 when I split the modes to prevent things like "accel tproxy" or
"tproxy transparent" from screwing up the client connection IPs.
I added the idea of a "mode" parameter at first position in the
sequence of http_port options and split the others into groups based on
the modes which used them. Squid parser can now warn/ignore/abort if
they are mixed in incompatible ways. The cf.data.pre shows how this mode
grouping works.
The 2.7 parser for "vhost" looks like (and similarly for the other
accel
specific options):
} else if (strcmp(token, "vhost") == 0) {
s->vhost = 1;
s->accel = 1;
Regards
Henrik
So you are in faviour of going back to the 2.7 behaviour where there
are effectively two near-identical reverse-proxy modes? one for virtual
hosting and one for non.
That would be a small code tweak and big documentation change. I'm good
for it if that is the way to go.
Amos
