On Sun, Jan 1, 2012 at 10:37 PM, Amos Jeffries <[email protected]> wrote: > This is part 1 of some SourceLayout changes for the DNS code. > > - removes "dnsserver" terminology from all the Squid internals and > ./configure docs. Replacing it with "helper" to avoid confusion. > > - updates the automake conditional to ENABLE_DNSHELPER and code define to > USE_DNSHELPER inline with coding guidelines. > > - shuffles the DNS API definitions to their own header, SquidDns.h, and > de-duplicates the init/shutdown API calls to remove some #if
I like the idea. Patch looks ok to me except that I don't fully understand the result of the condition removal in src/snmp_core.cc . If it is to return some never-incremented counters when snmp querying then it's a +1 from me. -- /kinkie
