On 17/08/2012 8:49 a.m., Kinkie wrote:
On Thu, Aug 16, 2012 at 6:00 PM, Alex Rousskov
<[email protected]> wrote:
On 08/16/2012 12:56 AM, Kinkie wrote:
I am guessing this is the patch that broke build in numerous places. I
am surprised it was not reverted upon the first signs of trouble. Here
are some of the errors that I see:
Prior to committing I have run a test-builds.sh on my kubuntu machine
and it turned out fine; apparently the more recent kernel and/or glibc
and/or gcc triggers some more permissive include paths.
AFAICT, the problems are related to missing #includes (a header that was
included via squid-old.h is no longer included). For example,
src/adaptation/ecap/MessageRep.cc is now missing protos.h, which
provides a urlParse() declaration.
A test build that enables ssl_crtd or eCAP could not succeed so I am
guessing your test-builds.sh does not enable them. I did not check
whether any other features are affected.
I agree, that is the expected source of problems right now.
"My" test-builds.sh is actually the whole build farm, whose status is:
CentOs-5, CentOS-5-icc, ubuntu-precise, debian-squeeze-arm,
freebsd-6.4 (west), mandriva, debian-unsatable: OK.
FreeBSD-9, OpenSUSE, MacOS-Leopard: fail due to problems in the Rock unit test
FreeBSD-9-clang: fail due to strtoll being misdetected
OpenBSD(all): fail due to library circular dependencies (Msg/CacheMgr)
Freebsd-7.2 (east), debian-sid-clang: fail due to system issues
Mswin: compat/ failing to completely fulfill its role.
In other words, none in 15 tested platforms shows the issue that
you're highlighting. If anything, this means that must the build tests
must be furhter improved: what can't be seen can't be fixed, despite
the best efforts one can put in place.
This sounds like the CRTD was not added to test-builds maximus listing
of switches to turn on.
I guess its time for another audit of ./configure flags to see what the
build levels should contain.
Amos
