On 06/13/2013 02:59 PM, Amos Jeffries wrote: > On 13/06/2013 2:44 a.m., Tsantilas Christos wrote: >> On 06/12/2013 10:56 AM, Henrik Nordström wrote: >>> ons 2013-06-12 klockan 14:25 +1200 skrev Amos Jeffries: >>>>>> Please also note in the descriptive message that this alters the >>>>>> documented behaviour of "Requests denied for logging will also not be >>>>>> accounted for in performance counters.", and now makes all traffic >>>>>> get >>>>>> performane counters accounting. >>>>> Are we OK with this? >>>> I am okay with the change. It just needs documenting so we don't >>>> overlook it in the release documentation. >>> We then may need some other way of excluding certain traffic from >>> accounting. >> A separate access list looks better in this case... >> Someone may need to log internal request but not count them to >> statistics... >> >> maybe the best is a mechanism to group statistics, like we do for logs. >> For example: >> statistics_group GROUPNAME acl1 acl2 acl3 >> >> And then in cache manager allow you to select global or group statistics >> :-) > > I think designing this properly will take some time and we will need > some different semantics as to what groups are etc, etc.
It was just a (maybe stupid) idea , not a proposal. I was not planned to implement it right now! > > As a temporary measure, how about adding a directive "log_stats > allow/deny acl acl acl ..." and using it only for the statistcs > gathering functions as done by "log_access allow"? OK. This is easy to implement and I think a good choice. I will post a new patch soon. > > That way we get this patch in quickly and can debate about new designs > for better statistics control later. > > Amos >
