+1. Much better. Still a bit more polishing which could be done during commit.

In particular we separate the client-side options from the server-side ones by splitting them into two groups one for each "side"....

* In cf.data.pre the options are listed as ablock of client-side codes, a block of squid-listening-port code, then server-side codes. You currently document the new >qos and >nfmark client-side codes in the server-side options. Please shuffle them into the client-side option group.

* In format/ByteCode.h we have similar "blocks" of related codes defined together. You have added these at the end of the enum. Please shuffle these new additions up next to the blocks of other LFT_CLIENT_LOCAL_* and LFT_SERVER_LOCAL_* enum codes as appropriate.

* In format/Format.cc we have (mostly) ordered the switch case statements to match the ByteCode.h definition order. Please shuffle those new case statements up to match the ByteCode.h changes.

Like I said these can be done on commit, or I will followup with a polish patch.

Amos

Reply via email to