I just ran your patch past my set of test cases built from the user complaints so far:

2013/07/31 04:56:39| Processing: configuration_includes_quoted_values off
...
2013/07/31 04:56:39| Processing: acl notAfunction url_regex ^somethingOLD(.*)
2013/07/31 04:56:39| Processing: acl notAmacro url_regex "somethingOLD$"
2013/07/31 04:56:39| Unsupported cfg macro: $"
FATAL: Bungled (#2) strings.conf line 23: acl notAmacro url_regex "somethingOLD$"



Of somewhat less importance there is also this weird case showing up when I create a bungled http_access line using parameters() in the OFF mode. This one is not specific to your patch, it happens with mine too, but it does worry me...

2013/07/31 04:56:39| Processing: configuration_includes_quoted_values off
...
2013/07/31 05:00:41| Processing: http_access parameters("foo")
2013/07/31 05:00:41| aclParseAccessLine: strings.conf line 18: http_access parameters("foo") 2013/07/31 05:00:41| aclParseAccessLine: Access line contains no ACL's, skipping 2013/07/31 05:00:41| Processing: acl notAfunction url_regex ^somethingOLD(.*) 2013/07/31 05:00:41| FATAL: Invalid ACL type 'notAfunction' for ACL named all FATAL: Bungled (#2) strings.conf line 21: acl notAfunction url_regex ^somethingOLD(.*)


Amos

Reply via email to