On 24/11/2013 9:29 a.m., Kinkie wrote: > Hi, > the attached patch records (and displays in cachemgr) the histogram > of the sizes of SBufs and MemBlobs. > > Builds and runs, but since SBuf is not yet used, no meaningful output > can be obtained. > The code lives as lp:~squid/squid/stringng (together with other not > yet merged SBuf bits, this is a cherrypick). >
in src/SBufDetailedStats.cc * please name the namespace in src/SBufDetailedStats.h * please add an empty line between code lines and each following comment. - same in src/StatHist.h * please make use of #ifndef safety wrappers in src/SBufStatsAction.cc * please move the warning text up to the top of the report. - I know its not part of this patch, but as you are altering it anyway... Amos
