Re: [PATCH] annotation support for external ACL helpers

[Eliezer Croitoru]

Now I just had small hole in time to look.
The mentioned logic seems pretty reasonable to me.

Eliezer

On 23/11/13 13:02, Amos Jeffries wrote:

          entryData.tag = label;
@@ -1603,6 +1605,18 @@
  {
      ACLFilledChecklist*checklist = Filled(static_cast<ACLChecklist*>(data));
      checklist->extacl_entry = cbdataReference((external_acl_entry *)result);
+
+    // attach the helper kv-pair to the transaction
+    if (HttpRequest * req = checklist->request) {
+        // XXX: we have no access to the transaction / AccessLogEntry so cant 
SyncNotes().
+        // workaround by using anything already set in HttpRequest
+        // OR use new and rely on a later Sync copying these to AccessLogEntry
+        if (!req->notes)
+            req->notes = new NotePairs;
+
+        req->notes->appendNewOnly(&checklist->extacl_entry->notes);
+    }
+
      checklist->resumeNonBlockingCheck(ExternalACLLookup::Instance());
  }