On 02/20/2014 06:03 PM, Amos Jeffries wrote: > On 20/02/2014 3:47 p.m., Alex Rousskov wrote: >> On 02/16/2014 08:42 PM, Amos Jeffries wrote: >>> On 17/02/2014 2:56 p.m., Alex Rousskov wrote: >>>> If my suggestion to add shutdown() and other methods to runners is >>>> accepted, I can help with the corresponding adjustments (both trunk and >>>> the proposed patch). >>>> >>>> If my suggestion is rejected, I will post my thoughts on how to adjust >>>> the proposed patch for the current two-action API. >> >> >>> It seems we have discussed this same topic at least three times now in >>> relation to as many components of Squid. >> >> Sorry if I missed an earlier indication of an agreement. >> >> >>> I am in agreement with the multi-action design. >> >> The attached patch implements the multi-action design. converts old code >> to use it, and adds a couple of new actions needed for the pending >> patches. Please review and feel free to commit if you like it (the patch >> preamble has the proposed commit message). >> >> Here is a typical action sequence from start to exit, with one >> reconfigure in between: >> >>> 19:24:40.290| main.cc(1450) SquidMain: running >>> RegisteredRunner::finalizeConfig >>> 19:24:40.290| main.cc(1451) SquidMain: running >>> RegisteredRunner::claimMemoryNeeds >>> 19:24:40.290| main.cc(1452) SquidMain: running RegisteredRunner::useConfig >>> 19:24:47.714| main.cc(809) mainReconfigureFinish: running >>> RegisteredRunner::syncConfig >>> 19:25:09.229| main.cc(278) doShutdown: running >>> RegisteredRunner::startShutdown >>> 19:25:11.078| main.cc(1943) SquidShutdown: running >>> RegisteredRunner::finishShutdown >> >> >> The patch has received only rudimentary testing -- the Vector change >> still appears to cause more problems on my test platform. Please test in >> your environment before commit, if any.
> +1. Committed to trunk (r13294). HTH, Alex.
