> I'm favour of this and have been for some time. However the patch does > not go far eonough to do what this submission claims. > > 1) do_mallinfo is removed in tools.cc but the globals.h and main.cc > parts of it are not removed.
Removed. > 2) The high_memory_warning directive now depends uniquely on HAVE_MSTATS > && HAVE_GNUMALLOC_H. > * Please add an cf.data.pre IFDEF check on those macros being defined Done > * Please update the directive documentation to omit mallinfo > and define the documentation. Done. > * perhapse a TODO entry about linking that directive to a mempools > capacity limit would be good idea. Done > 3) was --enable-snmp used at the time? > IIRC this should be interacting with some of the memory OID stats but I > don't seen any OID calculatiosn or docs being adjusted. It uses memPoolsTotalAllocated(), so nothing to do there. -- Francesco