On 12.05.14 18:20, Alex Rousskov wrote:
The Token class in v3.4 uses an ugly union (instead of "struct") for the data member. Thus, data.timespec should be identical to data.string. The fact that changing .timespec to .string makes a difference indicates that something else is probably broken.
Ok, I hadn't spotted that. On closer inspection, in 3.4.4 it is a union, but 3.4.5 changes it to a struct but doesn't initialise the timespec (which wasn't necessary when it was a union).
In any case, I don't see any reason for having both "timespec" and "string" since they are both the same thing, so I think removing timespec is still probably the right thing to do for the sake of readability.
-- - Steve Hill Technical Director Opendium Limited http://www.opendium.com Direct contacts: Instant messager: xmpp:[email protected] Email: [email protected] Phone: sip:[email protected] Sales / enquiries contacts: Email: [email protected] Phone: +44-844-9791439 / sip:[email protected] Support contacts: Email: [email protected] Phone: +44-844-4844916 / sip:[email protected]
