On 27/09/22 02:25, Alex Rousskov wrote:
On 9/26/22 05:51, Théo BARRAGUE wrote:

 entry is null so peerGetSomeNeighbor is never called

I did not check all the details, but it looks like Squid ICMP code (ab)uses StoreEntry-linked metadata. Basic CONNECT tunnels lack StoreEntry because they are not reading/writing data from/to Store. The combination is essentially a Squid bug -- basic CONNECT tunnels cannot use ICMP features.


CONNECT tunnel should be able to use data from ICMP like other code doing peer selection.


I see several bugs here:

1) ICMP relying on StoreEntry as a data source. The server (if not a cache_peer) being ping'ed should come from the CONNECT request object URI.

2) peer selection initiating ICMP directly. It should be retrieving RTT values from NetDB, which indirectly uses ICMP to get updates.


Cheers
Amos
_______________________________________________
squid-users mailing list
squid-users@lists.squid-cache.org
http://lists.squid-cache.org/listinfo/squid-users

Reply via email to