I finally found the bug in the code that I have bee commenting on.   Specifically on 
linux apache php 4.1.x (yes I will be upgrading) WHen I log in and mistype the user 
id and pass word in addition to the squirrel mail error message I get a php error.

The orginal code in sqm_topdir in display_messages.php seemed to be the 
problem.  It appears that in this case if a file of some name doesn't exist and you 
try 
and check if it is a directory you have a problem.  The following code change seems 
to make the error go away.  I can't see how it might break something.

function sqm_topdir(){
    $topdir = '';
    /**
     * $levels is just to avoid a potential infinite loop in case
     * things are REALLY broken. Shouldn't really ever happen.
     */
    $levels = 0;
    while (!(
             file_exists($topdir . 'functions') &&
             is_dir($topdir . 'functions') && 
             file_exists($topdir. 'src') &&
             is_dir($topdir. 'src')
             )
           && $levels < 10){
        $topdir .= '../';
        $levels++;
    }   
    return $topdir;
}    

How does one bring this to the developer's attention?



-------------------------------------------------------
This sf.net email is sponsored by:
With Great Power, Comes Great Responsibility 
Learn to use your power at OSDN's High Performance Computing Channel
http://hpc.devchannel.org/
--
squirrelmail-users mailing list
List Address: [EMAIL PROTECTED]
List Archives:  http://sourceforge.net/mailarchive/forum.php?forum_id=2995
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Reply via email to