> > This is an initial warning that the Personal Information of a user
> > can be corrupted with version 1.2.11.
> 
> > I upgraded from 1.2.10 to 1.2.11 with what seemed to be no problems.
> 
> > My first hint of a problem was IE 5.5 SP2 reporting it could not get
> > focus when running login.php because something is invisible.
> 
> That is an IE/JS problem. On the login page, we try to force focus
> onto the username box, but it isn't displayed before the code is run,
> so focus cannot be set.

Actually, if he is running the password_forget plugin, it adds another
input element on the login page, so the onLoad function breaks.  Because
there is no way to know if other plugins will do that, I changed that
part of the code to figure it out in a different way.  Here is what
/src/login.php should look like starting on line 95:

/* Output the javascript onload function. */

$header = "<SCRIPT LANGUAGE=\"JavaScript\" TYPE=\"text/javascript\">\n"
.
          "<!--\n".
          "  function squirrelmail_loginpage_onload() {\n".
          "    document.forms[0].js_autodetect_results.value = '" .
SMPREF_JS_ON . "';\n".
          "    var textElements = 0;\n".
          "    for (i = 0; i < document.forms[0].elements.length; i++)
{\n".
          "      if (document.forms[0].elements[i].type == \"text\" ||
document.forms[0].elements[i].type == \"password\") {\n".
          "        textElements++;\n".
          "        if (textElements == " . (isset($loginname) ? 2 : 1) .
") {\n".
          "          document.forms[0].elements[i].focus();\n".
          "          break;\n".
          "        }\n".
          "      }\n".
          "    }\n".
          "  }\n".
          "// -->\n".
          "</script>\n";


> > I have also noticed the session files remaining after a SignOut with
> > version 1.2.11 but no with 1.2.10
> 
> *sighs, banging head on desk*... It should _not_ be doing that any
> more. Can I point out how much I _hate_ sessions? ;) I'll have to look
> into this again. For some reason, despite the docs on PHP, the session
> does not get destroyed properly.

/me consoles Jonathan  ;>




-------------------------------------------------------
This SF.NET email is sponsored by: FREE  SSL Guide from Thawte
are you planning your Web Server Security? Click here to get a FREE
Thawte SSL guide and find the answers to all your  SSL security issues.
http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0026en
--
squirrelmail-users mailing list
List Address: [EMAIL PROTECTED]
List Archives:  http://sourceforge.net/mailarchive/forum.php?forum_id=2995
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Reply via email to