Hello John Madden,
On Wednesday, April 27, 2005, you wrote:

>> I was going to say "that should never happen", but if one web
>> server clobbers another's session file with a new user, it is
>> slightly possible, however you will never get the issue of you
>> deleting a message in one of your folders, and it deleting a
>> message in another. The code uses post variables to delete, so it's
>> just not possible for that to happen, but as I said, if the session
>> gets clobbered by another user, and it loads somebody elses user
>> information, then that is possible... though I'm not sure how PHP
>> keeps a handle on sessions to stop this happening in a non-load
>> balanced situation.

> I'm pretty sure I've seen that happen first-hand, although it's been
> awhile, so perhaps not. Another example: Delete/Move Next would
> jumble and end up deleting the wrong message and/or moving to the
> incorrect "next" message and/or displaying the body of the correct
> message with the headers of the incorrect one (that one's documented
> in the archives). Many times did I have to resort to digging through
> my Trash folder to recover a lost message...

Most of these would be caused by sessions... The delete_move_next
functionality relies heavily on the session information to retrieve
the next/previous message information.

> I thought I had read that PHP will flock() the session handles, but
> going back to read up on it now, I can't confirm that.

You did :)

  http://php.net/session-write-close

Basically summarized:

   Session data is usually stored after your script terminated without
   the need to call session_write_close(), but as session data is
   locked to prevent concurrent writes only one script may operate on
   a session at any time.

> However, it's easy to see that on a single web server, multiple
> clicks inside SQM (in separate frames) will not execute
> simultaneously, so some server-side serialization must be going on.

Okay, an example of why I believe the deletion of the wrong message
can/might happen in a load balanced situation, and using NFS for the
session storage.

  - User 1 logs in to webserver 1, gets session id abc123

  - User 2 logs in to webserver 2, gets session id abc123 and trashes
    current contents of abc123 session file

  - User 1 deletes a message using dmn plugin, uses wrong session
    information as user 2 has trashed file... wrong email removed

Though saying that, and describing the above situation, I still think
deleting the wrong email is impossible IF you are using UID support in
your imap server. The reason being is your IMAP server is assigning
unique identifiers for each message that SHOULD never change, and that
UID, along with the mailbox name is what is passed to the IMAP server
to be deleted (even if using the delete_move_next plugin). Now it is
possible that the wrong message appears AFTER you delete the message,
even with UID support enabled, but I don't think it is possible to
delete the wrong email

-- 
Jonathan Angliss
<[EMAIL PROTECTED]>



-------------------------------------------------------
SF.Net email is sponsored by: Tell us your software development plans!
Take this survey and enter to win a one-year sub to SourceForge.net
Plus IDC's 2005 look-ahead and a copy of this survey
Click here to start!  http://www.idcswdc.com/cgi-bin/survey?id=105hix
--
squirrelmail-users mailing list
Posting Guidelines: 
http://squirrelmail.org/wiki/wiki.php?MailingListPostingGuidelines
List Address: [email protected]
List Archives: 
http://news.gmane.org/thread.php?group=gmane.mail.squirrelmail.user
List Archives:  http://sourceforge.net/mailarchive/forum.php?forum_id=2995
List Info: https://lists.sourceforge.net/lists/listinfo/squirrelmail-users

Reply via email to