Just a side note for the future: passing structure variables as function 
parameters is not optimized if the structure is large (some compilers and 
static analyzers will complain). `str` is a small structure and it is fine, so 
not something that must to change here. Otherwise is recommended to pass the 
address (the pointer). What I mean is to have:

```
static int get_type(str *ctype)
```

instead of:

```
static int get_type(str ctype)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1787#issuecomment-451895137
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to