miconda commented on this pull request.


> +     if (get_str_fparam(&subst, msg, fp) != 0)
+       {
+               LM_ERR("error fetching subst re");
+               return -1;
+       }
+
+       LM_DBG("%s preparing %s\n", exports.name, subst.s);
+
+       se=subst_parser(&subst);
+       if (se==0)
+       {
+               LM_ERR("%s: bad subst re %s\n", exports.name, subst.s);
+               return E_BAD_RE;
+       }
+
+       return ops_subst(msg, (struct fis_param**)src, se);

I think that se needs to be freed, because subst_parser() allocates the result.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2158#pullrequestreview-324438268
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to