I pushed your commits manually, then followed up with a few commits making the 
changes:

  * increased the size of contact_addr filed to 255 (it can have parameters and 
then can become long, e.g., cases for ims or mobile devices)
  * contact_addr is optional value on RPC add command, `.` can be provided in 
such case to use the modparam value (to be easier to have the existing mode in 
the future, when one does not want to add per record value
  * contact_addr is last parameter in RPC add command, being the last added 
(you made it the previous last, but existing deployments should be easier to 
upgrade their cli tools by adding at the end instead of in the middle of cli 
parameters)

No testing though, should there be any problem after my additions, just open a 
bug report.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2470#issuecomment-689502842
_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to