@agranig commented on this pull request.
> @@ -324,6 +324,27 @@ modparam("mqtt", "ca_path", "/etc/ssl/certs")
<programlisting format="linespecific">
...
modparam("mqtt", "tls_method", "tlsv1.3")
+...
+ </programlisting>
+ </example>
+ </section>
+ <section id="mqtt.p.tls_alpn">
+ <title><varname>tls_alpn</varname> (str)</title>
+ <para>
+ Used to set the TLS ALPN option for cases where one TLS port is used
to share multiple services. Prominent
+ example is AWS IoT, where you have to set the
<varname>tls_alpn</varname> to "mqtt" to be able to connect
+ via MQTT.
+ </para>
+ <para>
+ <emphasis>
+ Default value is NULL, where no ALPN is set on the TLS
connection.
Alright. So, I will keep the docs for this commit as-is with the NULL, so it's
consistent with the documentation of the other params in this module. In
parallel, I've prepared another PR on top of this one, which changes the docs
of all module parameters at once, changing the wording from NULL to `Default
value is that option is not set ([description of implication this has, e.g.
random id or no auth or whatever])`. Agreed?
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3261#discussion_r994281090
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3261/review/1140246...@github.com>_______________________________________________
Kamailio (SER) - Development Mailing List
sr-dev@lists.kamailio.org
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
