Module: kamailio
Branch: master
Commit: e8ee31f6bce32050f8caaa8d053ddaea8d99cc1d
URL: 
https://github.com/kamailio/kamailio/commit/e8ee31f6bce32050f8caaa8d053ddaea8d99cc1d

Author: Daniel-Constantin Mierla <mico...@gmail.com>
Committer: Daniel-Constantin Mierla <mico...@gmail.com>
Date: 2024-01-20T12:16:13+01:00

lib/cds: reviewed and removed old comments

---

Modified: src/lib/cds/dbid.c
Modified: src/lib/cds/simple_profile.c
Modified: src/lib/cds/sstr.c

---

Diff:  
https://github.com/kamailio/kamailio/commit/e8ee31f6bce32050f8caaa8d053ddaea8d99cc1d.diff
Patch: 
https://github.com/kamailio/kamailio/commit/e8ee31f6bce32050f8caaa8d053ddaea8d99cc1d.patch

---

diff --git a/src/lib/cds/dbid.c b/src/lib/cds/dbid.c
index 5eb2ab20edc..fc4a47deb6d 100644
--- a/src/lib/cds/dbid.c
+++ b/src/lib/cds/dbid.c
@@ -9,7 +9,6 @@
 void generate_dbid_ptr(dbid_t dst, void *data_ptr)
 {
        /* TODO: add cluster distinctive member */
-       /* FIXME: replace sprintf by something more effective */
        snprintf(dst, MAX_DBID_LEN, "%px%xx%x", data_ptr, (int)time(NULL), 
rand());
 }
 
@@ -26,7 +25,6 @@ void generate_dbid(dbid_t dst)
        }
 
        /* TODO: add cluster distinctive member */
-       /* FIXME: replace sprintf by something more effective */
        snprintf(dst, MAX_DBID_LEN, "%xy%xy%xy%x", my_pid, cntr++, 
(int)time(NULL),
                        rand());
 }
diff --git a/src/lib/cds/simple_profile.c b/src/lib/cds/simple_profile.c
index f166ec8b0db..f20211776a0 100644
--- a/src/lib/cds/simple_profile.c
+++ b/src/lib/cds/simple_profile.c
@@ -4,9 +4,6 @@
 #include <sys/time.h>
 #include <string.h>
 
-/* FIXME: only for testing */
-/*#include "dprint.h"*/
-
 #define trace_signal SIGTRAP
 
 typedef void (*_sig_t)(int);
diff --git a/src/lib/cds/sstr.c b/src/lib/cds/sstr.c
index 5b065fdcbe5..a342fbb26dc 100644
--- a/src/lib/cds/sstr.c
+++ b/src/lib/cds/sstr.c
@@ -263,7 +263,6 @@ char *str_strchr(const str_t *s, char c)
 char *str_str(const str_t *s, const str_t *search_for)
 {
        int i, j;
-       /* FIXME: reimplement using better algorithm */
 
        if(is_str_empty(search_for))
                return s->s;

_______________________________________________
Kamailio (SER) - Development Mailing List
To unsubscribe send an email to sr-dev-le...@lists.kamailio.org

Reply via email to