@henningw commented on this pull request.
Thanks for the PR. I noticed something related to the script exports and docs,
see this comment. Just out of curiousity, which modules (class) would be the
user of this new API? Some existing modules, or do you plan to add another
module as well?
> @@ -203,6 +204,7 @@ static cmd_export_t cmds[] = {
{"prom_histogram_observe", (cmd_function)w_prom_histogram_observe_l1,
3, fixup_metric_reset, fixup_free_metric_reset, ANY_ROUTE},
{"prom_histogram_observe", (cmd_function)w_prom_histogram_observe_l2,
4, fixup_metric_reset, fixup_free_metric_reset, ANY_ROUTE},
{"prom_histogram_observe", (cmd_function)w_prom_histogram_observe_l3,
5, fixup_metric_reset, fixup_free_metric_reset, ANY_ROUTE},
+ {"bind_prom", (cmd_function)bind_prom, NO_SCRIPT, 0, 0, 0},
It looks that there are script exports for the new prom_gauge_incr missing
(similar to prom_counter_inc). These new functions need then also some
documentation in the XML docs.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4389#pullrequestreview-3202591846
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4389/review/[email protected]>_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
