pwakano left a comment (kamailio/kamailio#4169)

@miconda  , sorry to comment on a closed ticket, but I think this change has 
introduced a problem when closing a dialog via timeout when the caller BYE 
fails....
My scenario is the following, a webrtc client initiates a call and Kamailio is 
converting to UDP for the other end. The websocket is closed unexpectedly, then 
I capture this event and set a dialog timeout of 1s to terminate the call on 
the UDP end. This used to work on 5.8, but isn't anymore on 6.0.2. 
Upon checking the logs and changes I noticed this change is likely the cause, 
because now the dlg_bye_all only sends the BYE to the callee if the BYE to the 
caller returned 0, but in the webrtc case, it is failing with this error:
```
/usr/sbin/kamailio[2797042]: ERROR: <<null>:0> <core> [core/resolve.c:1773]: 
sip_hostport2su(): could not resolve hostname: "mywebrtc.invalid"
/usr/sbin/kamailio[2797042]: ERROR: <<null>:0> tm [ut.h:302]: uri2dst2(): 
failed to resolve "mywebrtc.invalid"
/usr/sbin/kamailio[2797042]: ERROR: <<null>:0> tm [uac.c:546]: t_uac_prepare(): 
no socket found
/usr/sbin/kamailio[2797042]: ERROR: <<null>:0> dialog [dlg_req_within.c:459]: 
send_bye(): failed to send the BYE request

```
so then the callee isn't sent a BYE due to this logic change:
```
-       ret = send_bye(dlg, DLG_CALLER_LEG, &all_hdrs);
-       ret |= send_bye(dlg, DLG_CALLEE_LEG, &all_hdrs);
+       ret = send_bye(dlg, DLG_CALLER_LEG, &all_hdrs, 0);
+       if(ret == 0) {
+               ret |= send_bye(dlg, DLG_CALLEE_LEG, &all_hdrs, 1);
+       }
```

The error to resolve "mywebrtc.invalid" doesn't happen for a normal BYE coming 
from the UDP end because the NAT handling uses the received/rport instead of 
resolving the VIA domain but in the timeout case this isn't working...
Is there anything I can do on the NAT handling side to overcome this situation 
or should I open/repopen a ticket in github?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/4169#issuecomment-3322422832
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/issues/4169/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to