zenichev left a comment (kamailio/kamailio#4559)
@miconda i've introduced the guards for the add and for the prepend
functionality.
But it turned out only the add functionality gets affected by it, because new
redis key members can in fact be <null>.
Meanwhile with the prepend functionality, even if the value to be prepended got
to be <null>, we don't care, because the eventual redis key value will not be
changed (either we return right away or pretend to prepend nothing). So we can
return from the function right away.
Which is not the case with the adding of the new key, whereas returning right
away upon having NULL pointer or 0 length, means never convert <null> redis
keys into empty "" one. So that's the main regression noticed so far.
It turns out such modules like dialog or usrloc want <null> members of redis
keys to be allowed.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4559#issuecomment-3769144920
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4559/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
