@miconda commented on this pull request.
> @@ -343,6 +343,9 @@ int replace_uri(struct sip_msg *msg, str *display, str
> *uri,
pkg_free(buf.s);
goto error;
}
+ } else {
+ /* deal with extra whitespace when the display is
removed */
+ l = del_lump(msg, body->display.s - msg->buf - 1, 1, 0);
It is not mandatory to have the space between the `:` after the header name and
the display name. If such space is not there, I think the above line is going
to delete the `:`, resulting in a broken header. A check to be sure there is a
white space should be done.
Looking at the code, maybe deleting the white space should combined with the
lump deleting the old display name, when the new display name is empty.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4586#pullrequestreview-3781433922
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4586/review/[email protected]>_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
