joelsdc left a comment (kamailio/kamailio#4575)
Hi @henningw,
Sorry for the delay! This is a bugfix, not a new user-visible feature. The
`xhttp_prom_tags` parameter already documents and implies that global tags
apply to all metrics, and they do work correctly for core/built-in metrics. The
bug was that user-defined custom counters were silently omitting those global
tags from their output.
So from a user's perspective, anyone who had configured `xhttp_prom_tags` and
was relying on those tags appearing consistently across all metrics (as
documented behavior would imply) was getting incorrect/incomplete output for
their custom metrics. This PR restores the expected behavior.
No documentation update should be needed, the intent was always that global
tags apply globally. This just makes the implementation match that intent.
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4575#issuecomment-3987249773
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4575/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
