henningw left a comment (kamailio/kamailio#4577)

Thanks for the PR. I did a quick review, it looked fine so far. The structure 
and naming of variables is a bit confusing, beeing an older part of the code, 
like having a srv structure that now also contains a naptr value. It should be 
also reviewed from another developer, e.g. @miconda before merging, I think.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4577#issuecomment-3989455663
You are receiving this because you are subscribed to this thread.

Message ID: <kamailio/kamailio/pull/4577/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the 
sender!

Reply via email to