rfuchs left a comment (kamailio/kamailio#4625)
> Having it controlled by a core parameter is good, therefore I haven't done
> right now a deep analysis, but the returned buffer that is linked inside
> sip_msg_t has to be at least BUF_SIZE in size, because some functions expects
> that. Because of that, the raw_buf should BUF_SIZE + max(haproxy headers
> size) + 1.
Ok wasn't aware of that. Fixed.
> Also, to cope with some older C specs/older OSes, the variables should be
> declared at the beginning of the block/function, in the PR, the `buf` was
> replaced by `raw_buf` and `buf` declared later in the middle of the function.
Good catch, I tried to keep that in mind, but missed that instance. Would be
nice to have that as a build check somewhere 😀
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/4625#issuecomment-4014515708
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/4625/[email protected]>
_______________________________________________
Kamailio - Development Mailing List -- [email protected]
To unsubscribe send an email to [email protected]
Important: keep the mailing list in the recipients, do not reply only to the
sender!
