Thank you for the report of the issue and accompanied patch to fix it.

A slightly different patch was pushed, to avoid compile and sanity checks 
warnings that the variable was set but not used, respectively dlginfo.

The changes to the documentation are not valid, the names there refer to the 
authors of the documentation, not to the authors of the code. There can be code 
written by different persons which have no relation with the module 
documentation for use in kamailio.cfg (which is what docs contain). Also, there 
was a new other name that was not involved in any discussions.

The code ownership is reflected by copyright strings at the top of the files. 
But that has to reflect relevant changes and must be additions, not removals. 
By removing a line added in the past by someone else, there is still no code 
done by you that can you ask copyright for it. Your name was mentioned in the 
commit message, as we do for all contributors.

Again, relevant c code additions can be accompanied with copyright line at the 
top of changed files. You must be aware that core and main components 
contributions must be under BSD license, contributions to modules that depend 
on libssl must grant OpenSSL GPL exception.

---
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/492#issuecomment-178442641
_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev

Reply via email to