linuxmaniac commented on this pull request.
> @@ -3238,11 +3238,11 @@ int pv_get_msg_attrs(sip_msg_t *msg, pv_param_t
> *param, pv_value_t *res)
int pv_parse_env_name(pv_spec_p sp, str *in)
{
+ char *csname;
+
if(in->s==NULL || in->len<=0)
I would do
```
if(sp==NULL || in == NULL || in->len <=0)
```
as in the
[kamailio-devel-guide](http://www.asipto.com/pub/kamailio-devel-guide/#c16_add_pv)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/978#pullrequestreview-20569726_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
