## Motivation
1. DOC says `setid` in mysql should be `UNSIGNED INT`:
http://www.kamailio.org/docs/modules/4.4.x/modules/rtpengine.html#rtpengine.p.table_name
http://www.kamailio.org/docs/modules/4.4.x/modules/rtpengine.html#rtpengine.p.setid_col
2. kamailio did report invalid value if `setid` less than 0.
3. kamailio rtpengine module declares setid as `int setid`, thus we can not use
setid more than 2147483647
This PR changes declaration of `setid` from `int` to `unsigned int`
## UNSURE (REVIEW NEEDED):
I'm not sure about:
should `int_val` in `fixup_set_ip` at
[rtpengine.c#L910](https://github.com/kamailio/kamailio/blob/master/src/modules/rtpengine/rtpengine.c#L910)
be declared as `unsigned int` as well?
not sure about the usage of `int pv_locate_name()` and `unsigned short str2s()`
in the `fixup_set_ip()` function.
should we use `str2int` instead `str2s` ?
let me know if I'm on the wrong direction
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/999
-- Commit Summary --
* rtpengine: really do allow unsigned setid
-- File Changes --
M src/modules/rtpengine/rtpengine.c (4)
M src/modules/rtpengine/rtpengine.h (2)
M src/modules/rtpengine/rtpengine_db.c (4)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/999.patch
https://github.com/kamailio/kamailio/pull/999.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/999
_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
