Is this patch useful in existing code base? If the function doesn't exist in
the db connector module, it should be not used by the modules, but do an
alternative solution. Can you give some example where this is useful now?
Anyhow, as I could understand from the patch, it doesn't do an update on an
insert conflict. This can mislead, by seeing the function exported by postgres
module, but not fully implemented.
Regarding the commit message, it must be strictly related to what the patch
adds/changes to Kamailio sources, not the story of doing the patch. Such
details can be in the pull requests description or comments of PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/1039#issuecomment-287618378
_______________________________________________
sr-dev mailing list
sr-dev@lists.sip-router.org
http://lists.sip-router.org/cgi-bin/mailman/listinfo/sr-dev
