the bitrig pedro_isakmpd branch has been created by pedro.

it is 0 commits behind master, and 1 commit ahead.

commit fe131cf3bd677b17e4627a5007ff8e952cd19920
diff: https://github.com/bitrig/bitrig/commit/fe131cf
author: pedro martelletto <[email protected]>
date: Wed Dec 10 15:40:01 2014 +0100

fix uninitialised memory use in isakmpd

x509_cert_get_subjects() in isakmpd/x509.c has the following code:

(*id)[0] = malloc((*id_len)[0]);
(...)
SET_ISAKMP_ID_TYPE((*id)[0] - ISAKMP_GEN_SZ, IPSEC_ID_DER_ASN1_DN);

this causes only the first byte of (*id)[0] to be filled; the remaining
three in the first word are left uninitialised. they don't seem to be
inspected anywhere, nor are they transmitted to peers, so this bug is
hopefully harmless.

M       sbin/isakmpd/x509.c

Reply via email to