On Wed, 2009-08-12 at 19:27 +0200, Jakub Hrozek wrote:
> + if (strcasecmp(ctx->name, "files") == 0) {
> + DEBUG(5, ("Rewriting provider %s\n", ctx->name));
> +
> + val[0] = "proxy";
> + ret = confdb_add_param(ctx->cdb, true,
> + ctx->conf_path,
> + "provider",
> + val);
> + if (ret) {
> + return ret;
> + }
> +
> + val[0] = "files";
> + ret = confdb_add_param(ctx->cdb, true,
> + ctx->conf_path,
> + "libName",
> + val);
> + if (ret) {
> + return ret;
> + }
> + }
Shouldn't you also check here if ctx->name is not "proxy" and the confdb
parameter "libName" isn't set to "files"? I'm not 100% sure, but it
seems to me, that if you have this in your sssd.conf:
provider = proxy
libName = files
then ctx->name will still be set to "proxy" and your test in
get_domain_type() will fail.
Also, I think it would be nice if you documented this shortcut in
server/man/sssd.conf.5.xml and server/examples/sssd.conf.
Martin
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
