-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 08/14/2009 11:09 PM, Dmitri Pal wrote: > Started looking at the ticket #107 related to > traverse functions. Realized that the return values > are not consistent. That overlapped with the work > that I wanted to do for ticket #103 - errno cleanup. > So I (across collection, INI and ELAPI): > * Made the return codes consistent (where found) > * Removed errno where it is not needed > While was testing used valgrind and found a nasty > problem when the value was added to collection with > overwriting duplicates the count was decreased improperly. > Fixing collection.c to not decrease count made > valgrind happy. While I was debugging this > I also spotted several build warnings in trace > statements when the " exp ? v1 : v2 " was used. > Fixed those. > In ini_config.c there was a trace statement that used > variable after it was freed. Removed trace statement. > > > > ------------------------------------------------------------------------ > > _______________________________________________ > sssd-devel mailing list > sssd-devel@lists.fedorahosted.org > https://fedorahosted.org/mailman/listinfo/sssd-devel
I am not reviewing this patch at this time, as it depends on another patch that was nacked. Please resubmit both when the original patch has been reviewed. - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkqJsacACgkQeiVVYja6o6P7JACghEZ6fKQdH9CgVDIo7gwB/NC8 UycAn3qFPCby6nJutVaSaAXgdbfZSH8y =rjx3 -----END PGP SIGNATURE----- _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel