-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 09/25/2009 07:14 AM, Sumit Bose wrote: > On Fri, Sep 25, 2009 at 06:58:38AM -0400, Stephen Gallagher wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> On 09/25/2009 06:53 AM, Jakub Hrozek wrote: >>> On 09/25/2009 12:22 PM, Stephen Gallagher wrote: >>>> Actually, I would prefer that we use this tool for potential future >>>> upgrades (that I hope never to have...). It would be better for it to >>>> detect which version is currently in place and upgrade it from 1 to 2, >>>> then 2 to 3, etc. internally and then write out the current version. >>> >>>> This way we don't need to change the spec file again for that, as well. >>> >>> >>> OK >>> >>>>>> >>>>>>>> - when using '-f /somewhere/my.conf' the backup is created in >>>>>>>> /somewhere >>>>>>>> but the new config is written to /etc/sss/sssd.conf. My expectation >>>>>>>> was >>>>>>>> that the conversion would be done in-place. If you prefer it this way >>>>>>>> '--help' should say that the default output file is >>>>>>>> /etc/sss/sssd.conf >>>>>> >>>>>> >>>>>> Fixed, thanks >>>> Uh, this doesn't look right to me: >>>> + if options.filename and not options.outfile: >>>> + options.outfile = options.filename >>>> + if not options.outfile: >>>> + options.outfile = '/etc/sssd/sssd.conf' >>> >>>> I think that second if needs to be elif, otherwise you're always going >>>> to override setting options.outfile = options.filename >>> >>> >>> D'oh.. >>> >>> the logic is fixed (note the default options are /etc/sssd/sssd.conf and >>> None respectively) >>> >>> >>> Jakub >> >> Ack from me. >> > > ACK from me too > > bye, > Sumit > _______________________________________________ > sssd-devel mailing list > sssd-devel@lists.fedorahosted.org > https://fedorahosted.org/mailman/listinfo/sssd-devel
All three patches pushed to master - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkq8wX8ACgkQeiVVYja6o6MHJgCdF0qrHGcL8GfA70do8SDGggKC bz4AoI7dApbM8GFh0ANewRM8X25X4cls =rbeX -----END PGP SIGNATURE----- _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
