On Thu, 2009-10-15 at 14:14 -0400, Stephen Gallagher wrote: > On 10/15/2009 01:24 PM, Simo Sorce wrote: > > On Thu, 2009-10-15 at 12:51 -0400, Stephen Gallagher wrote: > >> Most of these warnings are seen only on older platforms like RHEL5. > >> > >> 0001: Clean up warnings in pysss.c > > > > Shouldn't we just use discard_const_p() in these cases ? > > It doesn't look like the underlying code is ever going to change the > > format string anyway, so discard_const_p() would be safe and would avoid > > a lot of memory allocation. > > Yeah, you're right. Revised patch attached. > > Related: There are some places in pysss.c (specifically the > initialization of sss_local_methods) where we cannot use > discard_const_p, and the older python headers are expecting a char *. > Any ideas how to solve that? (It's not a blocking issue for this patch, > but it would allow us to come closer to a warning-free build) > > > > >> 0002: Remove warnings caused by > >> 5e2301b8a75d10e5cbbe11e26e5192b894af6ad7 > > ack > > > >> 0003: Remove two unused functions. > > ack
ack 0001 and pushed all three. Simo. -- Simo Sorce * Red Hat, Inc * New York _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
