Comment in patch says all.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
>From cf01eae6e4518c1abdd75c37b0796d468e76eaa5 Mon Sep 17 00:00:00 2001
From: Simo Sorce <sso...@redhat.com>
Date: Wed, 11 Nov 2009 20:44:23 -0500
Subject: [PATCH] Change var name to make its use more clear.
Change memctx to make clear it should be used only when a callback is being
used.
---
server/responder/common/responder.h | 2 +-
server/responder/common/responder_dp.c | 12 ++++++------
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/server/responder/common/responder.h b/server/responder/common/responder.h
index 439bf87..a597e68 100644
--- a/server/responder/common/responder.h
+++ b/server/responder/common/responder.h
@@ -143,7 +143,7 @@ struct cli_protocol_version *register_cli_protocol_version(void);
typedef void (*sss_dp_callback_t)(uint16_t err_maj, uint32_t err_min,
const char *err_msg, void *ptr);
-int sss_dp_send_acct_req(struct resp_ctx *rctx, TALLOC_CTX *memctx,
+int sss_dp_send_acct_req(struct resp_ctx *rctx, TALLOC_CTX *callback_memctx,
sss_dp_callback_t callback, void *callback_ctx,
int timeout, const char *domain, int type,
const char *opt_name, uint32_t opt_id);
diff --git a/server/responder/common/responder_dp.c b/server/responder/common/responder_dp.c
index 236755f..943b72c 100644
--- a/server/responder/common/responder_dp.c
+++ b/server/responder/common/responder_dp.c
@@ -232,7 +232,7 @@ error:
}
static int sss_dp_send_acct_req_create(struct resp_ctx *rctx,
- TALLOC_CTX *memctx,
+ TALLOC_CTX *callback_memctx,
const char *domain,
uint32_t be_type,
char *filter,
@@ -241,7 +241,7 @@ static int sss_dp_send_acct_req_create(struct resp_ctx *rctx,
void *callback_ctx,
struct sss_dp_req **ndp);
-int sss_dp_send_acct_req(struct resp_ctx *rctx, TALLOC_CTX *memctx,
+int sss_dp_send_acct_req(struct resp_ctx *rctx, TALLOC_CTX *callback_memctx,
sss_dp_callback_t callback, void *callback_ctx,
int timeout, const char *domain, int type,
const char *opt_name, uint32_t opt_id)
@@ -329,7 +329,7 @@ int sss_dp_send_acct_req(struct resp_ctx *rctx, TALLOC_CTX *memctx,
goto done;
}
- cb = talloc_zero(memctx, struct sss_dp_callback);
+ cb = talloc_zero(callback_memctx, struct sss_dp_callback);
if (!cb) {
ret = ENOMEM;
goto done;
@@ -350,7 +350,7 @@ int sss_dp_send_acct_req(struct resp_ctx *rctx, TALLOC_CTX *memctx,
/* No such request in progress
* Create a new request
*/
- ret = sss_dp_send_acct_req_create(rctx, memctx, domain,
+ ret = sss_dp_send_acct_req_create(rctx, callback_memctx, domain,
be_type, filter, timeout,
callback, callback_ctx,
&sdp_req);
@@ -402,7 +402,7 @@ done:
}
static int sss_dp_send_acct_req_create(struct resp_ctx *rctx,
- TALLOC_CTX *memctx,
+ TALLOC_CTX *callback_memctx,
const char *domain,
uint32_t be_type,
char *filter,
@@ -478,7 +478,7 @@ static int sss_dp_send_acct_req_create(struct resp_ctx *rctx,
sdp_req->pending_reply = pending_reply;
if (callback) {
- cb = talloc_zero(memctx, struct sss_dp_callback);
+ cb = talloc_zero(callback_memctx, struct sss_dp_callback);
if (!cb) {
dbus_message_unref(msg);
talloc_zfree(sdp_req);
--
1.6.2.5
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
