On Mon, 2009-12-07 at 09:51 -0500, Dmitri Pal wrote: > 0002 - Dhash improvement. See patch comments. (independent patch)
I am leaning on nacking this one. It is redundant and basically just duplicates code. The only difference between hash_lookup+hash_delete and hash_remove is one less lookup, if that's the point one can simply modify hash_delete to return the value, or not modify anything and use the delete_callback. Duplicating code is not the best way. Simo. -- Simo Sorce * Red Hat, Inc * New York _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
