On Wed, 2009-12-09 at 15:13 -0500, Stephen Gallagher wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 12/09/2009 02:26 PM, Stephen Gallagher wrote: > > On 12/09/2009 12:21 PM, Sumit Bose wrote: > >> Hi, > > > >> this is a quick fix for #285 by calling sysdb_upgrade_03() after > >> sysdb_upgrade_02() is done. I'm thinking of refactoring all the upgrade > >> calls into one function which can be called multiple time from different > >> places of the code, but for the time being I think the patch is > >> sufficient. > > > >> bye, > >> Sumit > > > > > > > > Nack. > > > > The DEBUG statement for the upgrade to version 3 should use %s (like the > > change you made to the other one). > > > > Also, please s/form/from/ in both messages. > > > > Attached patch fixes the above concerns.
Ack Also see attached followup patch to further upgrade to 05 Simo. -- Simo Sorce * Red Hat, Inc * New York
>From 75025a1f9557a94b6e8ff75b6343af777754a627 Mon Sep 17 00:00:00 2001 From: Simo Sorce <sso...@redhat.com> Date: Thu, 10 Dec 2009 15:31:41 -0500 Subject: [PATCH] Handle the special 02 upgrade case for 04->05 --- server/db/sysdb.c | 7 +++++++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/server/db/sysdb.c b/server/db/sysdb.c index f481e0d..7666c78 100644 --- a/server/db/sysdb.c +++ b/server/db/sysdb.c @@ -1775,6 +1775,13 @@ int sysdb_init(TALLOC_CTX *mem_ctx, talloc_zfree(ctx_list); return ret; }; + ret = sysdb_upgrade_04(ctx, &version); + if (ret != EOK) { + DEBUG(0, ("FATAL: Upgrade from db version %s failed!\n", + SYSDB_VERSION_0_4)); + talloc_zfree(ctx_list); + return ret; + }; } *_ctx_list = ctx_list; -- 1.6.2.5
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel