On Tue, Feb 09, 2010 at 10:39:28PM +0100, Jakub Hrozek wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 02/09/2010 02:08 PM, Jakub Hrozek wrote:
> > Although I did not manage to reproduce the segfault, the backtrace
> > looked like an uninitialized "nmembers" variable..new patch is attached.
> >
>
> Several other improvements related to the way we display info about the
> MPGs were discussed off-list, this patch factors them in.
>
> Jakub
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAktx1hAACgkQHsardTLnvCVXNwCfedeYn+IVQg0TAGBwSbn1svcA
> AToAoJ97bOeTXJCmSwOgJavGFbWZc2Cm
> =2tqm
> -----END PGP SIGNATURE-----
> +
> + subreq = group_show_recurse_send(state->root, state,
> + state->root,
> + group_members,
> + nmembers);
> + if (ret != EOK) {
> + tevent_req_error(req, ret);
> + return;
> + }
> + tevent_req_set_callback(subreq, group_show_recurse_done, req);
> +}
> +
I think 'if (!subreq)' fits better here.
bye,
Sumit
_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel
