-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 05/27/2010 05:29 PM, Stephen Gallagher wrote: > I'd prefer not to include that in this patch. As best I can tell, it's > only an issue in the NSS proxy routines, not PAM. >
OK, agreed. > We should not be initializing ret, we should be guaranteeing that it is > always returned with an appropriate value. > If we initialize it, we're > potentially hiding an error. Just to clarify why I was suggesting initializing..the call that is supposed to fill *ret is ctx->ops.initgroups_dyn which points to to nss-ldap's _nss_ldap_initgroups_dyn(). Since it's already external call, initializing the ret variable seemed OK to me. > That's a much bigger task and deserves its > own ticket (please open one) and patch. > Done: https://fedorahosted.org/sssd/ticket/498 > If you have no other issues with this patch, I will push it as-is. ACK, go ahead -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkv+lT4ACgkQHsardTLnvCUdGgCg0bqGvkEU5UwJVzh9wBwNFl+l /goAoOFWPs86HFVnyR/Ac3wmElTDtcCh =w6xO -----END PGP SIGNATURE----- _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
