-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 07/05/2010 08:21 AM, Jakub Hrozek wrote: > Integrates libnl to detect adding routes. When a route is added, the > offline status of all back ends is reset. This patch adds no heuristics > to detect whether back end went offline. > > Fixes: #456
Nack. sssd.spec.in needs to have a BuildRequires added for libnl-devel setup_netlink() should set *_nlctx = NULL when HAVE_LIBNL is not defined. I don't like having both HAVE_LIBNL_OLDER_THAN_1_1 and HAVE_LIBNL_AT_LEAST_1_1 defined. Please pick one and stick with it. Furthermore, if possible I'd rather you base this decision on the existence of the nl_socket_get_fd(), nl_set_passcred(), nl_socket_add_membership() and nl_socket_modify_cb() functions, rather than relying on pkgconfig reporting a version number correctly. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkw0tPEACgkQeiVVYja6o6M+hACaAhDmPkKaL/BkhOhCJXTIuWNX 6lAAnjBmC3dzqoj5cqKe7ff0jGFFTibO =Gh1p -----END PGP SIGNATURE----- _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
