Stephen Gallagher <sgall...@redhat.com> wrote: > >> 0005-Deleted-some-needless-assignments.patch > >> Ticket: #582 > > > > I think we should check for potential errors from sdap_id_op_done() > > calls instead of removing the assignments altogether. > > I agree with Jakub. These assignments shouldn't be removed, they should > be tested for failures.
Sorry for an extra email, forgot to mention this in the previous one. I don't think this is the case. The result of operation is subsequently checked (it is stored also in dp_error variable). We can check ret value as well as dp_error, but I don't think it will bring any code improvement. The same applies for call of sysdb_attrs_get_string() - its return value isn't checked, but the content of "value" variable is tested. Jan _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel