On Tue, Sep 21, 2010 at 05:49:14PM -0400, Stephen Gallagher wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> We rethought how we're going to build the ding-libs.
> 
> They will now all be built from a single tarball (and a single SRPM, by
> extension) and produce independent shared libraries (which will produce
> an assortment of binary subpackages in RPM)
> 
> The attached (large) patch makes this change by moving all of the
> ding-libs into a common Makefile.am/configure.ac pair at the root of the
> source tree.
> 
> 
> Dmitri, I have rebased my FedoraPeople repo branch with these changes,
> so developing from that as a base should work for you.
> 
> http://fedorapeople.org/gitweb?p=sgallagh/public_git/ding-libs.git;a=shortlog;h=refs/heads/dpal
> 
> Let me know if you have trouble.

Hi,

I have a few comments:

- I think a toplevel m4 directory is missing and all m4 directories from
the subdirectories can be removed.
- The README file needs an update to reflect the changes.
- there is an empty last line in version.m4

With the m4 directory changes I was able to run 'make distcheck', 'make
rpms' and friends without any issue.

bye,
Sumit

> 
> - -- 
> Stephen Gallagher
> RHCE 804006346421761
> 
> Delivering value year after year.
> Red Hat ranks #1 in value among software vendors.
> http://www.redhat.com/promo/vendor/
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/
> 
> iEYEARECAAYFAkyZKFkACgkQeiVVYja6o6P74QCfYFcDT5V61rMN9WHCsBOim3O0
> hAMAn1i620mra4wzGNGl6EGmFa/BFLNB
> =C+OV
> -----END PGP SIGNATURE-----

_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to