On Fri, 28 Jan 2011 07:46:03 -0500 Stephen Gallagher <sgall...@redhat.com> wrote:
> Patch 0002: While investigating the above, I also realized that the > dataExpireTimestamp attribute (which we use as the primary search > expression for expired entries) wasn't listed as an indexed attribute. > This means that searches over a large sysdb database (e.g. one with > enumerate = true) was significantly slower than it should be. This > patch adds dataExpireTimestamp as an indexed attribute. Good idea, but I have 2 remarks. 1 given you are going to update the db number, why don't you squash in the relevant parts of the patch I sent a while ago to add also one level indexes ? 2. I think you should drop memberof rebuilding. That is a very expensive operation and there is nothing in your patches that requires it, as nothing is changed in the memberof plugin nor we are aware of any issue generating memberof attributes since the previous version. Simo. -- Simo Sorce * Red Hat, Inc * New York _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
