-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 03/17/2011 10:09 AM, Sumit Bose wrote: > On Thu, Mar 17, 2011 at 09:57:22AM -0400, Stephen Gallagher wrote: > > When we added the Kerberos access provider (for support of .k5login), we > forgot to include it in the SSSDConfig API schema. > > Fixes https://bugzilla.redhat.com/show_bug.cgi?id=688491 > >> NACK, test fails, please add > >> diff --git a/src/config/SSSDConfigTest.py b/src/config/SSSDConfigTest.py >> index 60fb0a2..22370c0 100755 >> --- a/src/config/SSSDConfigTest.py >> +++ b/src/config/SSSDConfigTest.py >> @@ -693,7 +693,7 @@ class SSSDConfigTestSSSDDomain(unittest.TestCase): >> 'ipa': ['id', 'auth', 'access', 'chpass'], >> 'local': ['id', 'auth', 'chpass'], >> 'ldap': ['id', 'auth', 'access', 'chpass'], >> - 'krb5': ['auth', 'chpass'], >> + 'krb5': ['auth', 'chpass', 'access'], >> 'proxy': ['id', 'auth'], >> 'simple': ['access'], >> 'permit': ['access'], >
See, this is exactly why I like to send reviews even for one-liners. Thanks, I should have remembered to run the test. New patch attached. - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAk2CHaEACgkQeiVVYja6o6NnhgCgrwYDZUg45mJcc6saR5dmeHxc gbQAn0DGn//M3mNpA5E55pSEBbO5gruZ =IX5u -----END PGP SIGNATURE-----
From 3683dda507904a20e697a777eb94d3bba2972fa2 Mon Sep 17 00:00:00 2001 From: Stephen Gallagher <[email protected]> Date: Thu, 17 Mar 2011 09:55:57 -0400 Subject: [PATCH] Add support for krb5 access provider to SSSDConfig API --- src/config/SSSDConfigTest.py | 2 +- src/config/etc/sssd.api.d/sssd-krb5.conf | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/config/SSSDConfigTest.py b/src/config/SSSDConfigTest.py index 60fb0a2443a7f51ada8575bca1cf934f262b3bc1..cad183ea00722f86c59c4c66705634836dee6c40 100755 --- a/src/config/SSSDConfigTest.py +++ b/src/config/SSSDConfigTest.py @@ -693,7 +693,7 @@ class SSSDConfigTestSSSDDomain(unittest.TestCase): 'ipa': ['id', 'auth', 'access', 'chpass'], 'local': ['id', 'auth', 'chpass'], 'ldap': ['id', 'auth', 'access', 'chpass'], - 'krb5': ['auth', 'chpass'], + 'krb5': ['auth', 'access', 'chpass'], 'proxy': ['id', 'auth'], 'simple': ['access'], 'permit': ['access'], diff --git a/src/config/etc/sssd.api.d/sssd-krb5.conf b/src/config/etc/sssd.api.d/sssd-krb5.conf index bb3a077d2b938520a07f21de1cbb4c098b3d911a..79c67aeacc3d50485df43e788771e940d9f0976c 100644 --- a/src/config/etc/sssd.api.d/sssd-krb5.conf +++ b/src/config/etc/sssd.api.d/sssd-krb5.conf @@ -16,5 +16,7 @@ krb5_lifetime = str, None, false krb5_renew_interval = int, None, false krb5_use_fast = str, None, false +[provider/krb5/access] + [provider/krb5/chpass] -- 1.7.4
0001-Add-support-for-krb5-access-provider-to-SSSDConfig-A.patch.sig
Description: PGP signature
_______________________________________________ sssd-devel mailing list [email protected] https://fedorahosted.org/mailman/listinfo/sssd-devel
