On Mon, 2012-01-23 at 16:29 +0100, Jakub Hrozek wrote:
> On Sun, Jan 22, 2012 at 07:32:28PM -0500, Stephen Gallagher wrote:
> > On Sun, 2012-01-22 at 20:34 +0100, Jakub Hrozek wrote:
> > > On Sat, Jan 21, 2012 at 05:12:49PM -0500, Stephen Gallagher wrote:
> > > > On Thu, 2012-01-19 at 13:51 +0100, Jakub Hrozek wrote:
> > > > > [PATCH 1/2] HBAC docs: Fix path to libipa_hbac header file
> > > > > I noticed the HBAC docs directory contained just a stub index.html
> > > > > 
> > > > > [PATCH 2/2] SUDO: Provide documentation for the SUDO API
> > > > > The API should be documented in order to be easily consumable by the
> > > > > SUDO project
> > > > 
> > > > Nack.
> > > > I applied these two patches, ran configure and then 'make && make docs'
> > > > and only got a stub index.html for both of them.
> > > > 
> > > > Note: I build in a parallel build directory. It's possible that this is
> > > > where the disconnect is occurring.
> > > 
> > > You're right, I only tested in-tree build. I think I don't quite 
> > > understand
> > > how autoconf substitutions work for srcdir subdirectories.
> > > 
> > > If I build in-tree, then @srcdir@ is substituted for "." which is what
> > > I'd expect.
> > > 
> > > However, when I build in a parallel dir and run:
> > > $ /path/to/sssd/configure $options
> > > then the relative path inside sssd tree is appended to
> > > /path/to/sssd and @srcdir@ expands to /path/to/sssd/src/providers/ipa/
> > > in ipa_hbac.doxy. This seems confusing, I would still expect only
> > > /path/to/sssd/.
> > 
> > Yeah, that's quite strange. @srcdir@ *is* supposed to be /path/to/sssd
> > there. Could be an autoconf bug :(
> 
> My autoconf-fu is not that strong but Sumit directed me to @top_srcdir@
> and @abs_top_srcdir@ which seem to work fine.
> 
> New patches attached.

Please test these on RHEL 5. I seem to recall that abs_top_srcdir isn't
available there. (I think we had to hack around that in some other parts
of the build environment, either in SSSD or ding-libs).

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to