On Thu, 2012-02-02 at 21:28 -0500, Stephen Gallagher wrote: > On Thu, 2012-02-02 at 12:50 +0100, Jakub Hrozek wrote: > > On Tue, Jan 31, 2012 at 08:29:15PM -0500, Stephen Gallagher wrote: > > > On Tue, 2012-01-31 at 15:56 +0100, Jakub Hrozek wrote: > > > > On Wed, Jan 25, 2012 at 08:23:23PM +0100, Jakub Hrozek wrote: > > > > > On Fri, Jan 20, 2012 at 01:22:19PM +0100, Pavel Březina wrote: > > > > > > Dne 18.1.2012 10:30, Jakub Hrozek napsal(a): > > > > > > >On Wed, Jan 18, 2012 at 10:16:14AM +0100, Jakub Hrozek wrote: > > > > > > >>On Wed, Jan 18, 2012 at 10:05:23AM +0100, Jan Zelený wrote: > > > > > > >>>>https://fedorahosted.org/sssd/ticket/1116 > > > > > > >>>> > > > > > > >>>>Adds option 'sudo_timed' to responder. > > > > > > >>> > > > > > > >>>Ack. I didn't perform any real-life testing but the patch seems > > > > > > >>>simple enough. > > > > > > >>> > > > > > > >>>Thanks > > > > > > >>>Jan > > > > > > >> > > > > > > >>Real life testing cannot be performed until the sudo side is > > > > > > >>ready. > > > > > > >> > > > > > > >>That's also why I asked Pavel to hold sending out this patch for > > > > > > >>review > > > > > > >>until he can actuall test it. > > > > > > > > > > > > > >Also, nack. The new option needs to be added into the config API. > > > > > > > > > > > > I think this should be done as part of #1144 [1] or #1144 should be > > > > > > done as a part of this patch (preferably because this is going to be > > > > > > the only responder related option so far). > > > > > > > > > > > > [1] https://fedorahosted.org/sssd/ticket/1144 > > > > > > > > > > You're right, I didn't realize it was the only option. Then please > > > > > include the changes into this patch and we can close both tickets. > > > > > > > > > > Also, this patch needs rebasing on top of the latest iteration of > > > > > "cn=defaults" patches. > > > > > > > > I grabbed Pavel's WIP patch, and made some fixes (to separate the work, > > > > attached as Patch #2). > > > > > > This doesn't apply atop the current master. Please rebase it. (It also > > > looks like maybe there's a missing patch in the series?) > > > > Yes, sorry, I had the in-memory cache in my tree before the timed > > patches. Instead of rebasing the timed patches on top of master and then > > the other way around, I dediced to finish the in-memory patch. > > > > I'm attaching the patches again, there are no changes in the code, just > > rebase on top of the changed in the in-memory patch. > > Looks good to me. Ack.
Pushed to master.
signature.asc
Description: This is a digitally signed message part
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel
