On Fri, 2012-05-04 at 21:41 +0200, Stef Walter wrote:
> On 05/04/2012 07:01 PM, Stephen Gallagher wrote:
> >> Will attach simple patch which fixes the problem. An alternate patch
> >> would be to use krb5_get_init_creds_opt_set_out_ccache() instead of
> >> writing the credential cache in sssd code.
> > 
> > Thanks for the patch! Just a few things:
> > 
> > Please add a comment stating the reason to use my_creds.client instead
> > of kprinc so future developers don't get confused.
> 
> Done.
> 
> > Also, this change needs to be made to src/providers/krb5/krb5_child.c as
> > well. From discussion on IRC, "create_ccache_file() could lose the
> > krb5_principal argument and always use the one in the creds".
> 
> Updated krb5_child.c. Didn't change signature of create_ccache_file() as
> its called with NULL creds sometimes.
> 
> New patch attached,

Ack and pushed to master.

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel

Reply via email to